Add a simplified version of the dom elements#41
Merged
mjrussell merged 3 commits intopurescript-react:mainfrom Jul 8, 2022
Merged
Add a simplified version of the dom elements#41mjrussell merged 3 commits intopurescript-react:mainfrom
mjrussell merged 3 commits intopurescript-react:mainfrom
Conversation
| import Unsafe.Coerce (unsafeCoerce) | ||
|
|
||
| -- | Create a text node. | ||
| text :: String -> JSX |
Member
There was a problem hiding this comment.
This already exists, right?
Member
Author
There was a problem hiding this comment.
Yes but I couldn't just import it because this would result in a cyclic dependency. I think I could just move the unsafeCoerce into the typeclass anyway
Member
Author
|
@mjrussell can you have a look at this? |
Member
|
Thanks for the ping, sorry this has lagged a bit. I think the overall proposal is good and it looks like a nice improvement. Definitely 👍 on a different module. Does this have any changes when moving to React 18? I was hoping to try to get #44 in first and then merge this |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simplified version of the dom elements (insipired by how
elmish-htmldoes it) to make it less boilerplatey to work with simple html elements. I added them in a separate module to avoid backwards-compatibility issues. Basically, this change allows you to write elements like this: